-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: センシティブフラグ変更の由来をdrive_fileに持つ #15452
Open
samunohito
wants to merge
15
commits into
misskey-dev:develop
Choose a base branch
from
samunohito:enhance/15443-sensitive-reason
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
enhance: センシティブフラグ変更の由来をdrive_fileに持つ #15452
samunohito
wants to merge
15
commits into
misskey-dev:develop
from
samunohito:enhance/15443-sensitive-reason
+166
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
このPRによるapi.jsonの差分 差分はこちら--- base
+++ head
@@ -33774,6 +33774,15 @@
}
}
},
+ "NSFW_MARKED_BY_MODERATOR": {
+ "value": {
+ "error": {
+ "message": "Cannot be removed because it has been flagged as NSFW by a moderator.",
+ "code": "NSFW_MARKED_BY_MODERATOR",
+ "id": "c9ff65ab-c344-d715-f3c8-0c325f852951"
+ }
+ }
+ },
"INVALID_PARAM": {
"value": {
"error": {
@@ -80914,6 +80923,15 @@
"isSensitive": {
"type": "boolean"
},
+ "sensitiveChangeReason": {
+ "type": "string",
+ "enum": [
+ "user",
+ "moderator",
+ "auto",
+ "none"
+ ]
+ },
"blurhash": {
"type": [
"string",
@@ -81005,6 +81023,7 @@
"md5",
"size",
"isSensitive",
+ "sensitiveChangeReason",
"blurhash",
"properties",
"url", |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #15452 +/- ##
============================================
+ Coverage 18.83% 40.33% +21.50%
============================================
Files 768 1611 +843
Lines 111567 210779 +99212
Branches 1236 4087 +2851
============================================
+ Hits 21013 85020 +64007
- Misses 89963 125117 +35154
- Partials 591 642 +51 ☔ View full report in Codecov by Sentry. |
5d133cd
to
3e1727d
Compare
open |
バックエンドのe2eのほうのテストがあったほうが良さそう |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
packages/backend:test
packages/backend
Server side specific issue/PR
packages/frontend
Client side specific issue/PR
packages/misskey-js
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
モデレータによりセンシティブ設定されたファイルは、ユーザ側から非センシティブ化出来ないようにします。
drive_file.isSensitiveが誰による操作で更新されたかを保持し、以下のすべてを満たす場合はエラーとするようにしました。
Why
fix #15443
Additional info (optional)
ローカルで以下を動作確認
Checklist